From 792f0f897780b747b2c5677dfa39c2d402cefac9 Mon Sep 17 00:00:00 2001
From: Devin Foley <devin@devinfoley.com>
Date: Fri, 3 Apr 2026 08:55:37 -0700
Subject: [PATCH] fix: address Greptile review feedback on screenshot utility

- P1: Replace process.exit(1) with process.exitCode = 1 so the finally
  block runs and browser.close() is called on failure
- P2: Fix flag parsing to handle --wait 0 correctly using Number.isNaN
  instead of falsy || fallback
- P2: Scope Bearer token to Paperclip origin only via page.route()
  instead of extraHTTPHeaders on all requests

Co-Authored-By: Paperclip <noreply@paperclip.ing>
---
 scripts/screenshot.cjs | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/scripts/screenshot.cjs b/scripts/screenshot.cjs
index 052c5f4922d..141468f9466 100644
--- a/scripts/screenshot.cjs
+++ b/scripts/screenshot.cjs
@@ -23,7 +23,7 @@ function flag(name, fallback) {
   const i = args.indexOf(`--${name}`);
   if (i === -1) return fallback;
   const val = args.splice(i, 2)[1];
-  return Number(val) || fallback;
+  return Number.isNaN(Number(val)) ? fallback : Number(val);
 }
 const width = flag("width", 1280);
 const height = flag("height", 800);
@@ -64,14 +64,18 @@ const url = rawUrl.startsWith("http") ? rawUrl : `${cred.apiBase}${rawUrl}`;
 (async () => {
   const { chromium } = require("playwright");
   const browser = await chromium.launch();
+  const origin = new URL(url).origin;
   const context = await browser.newContext({
     viewport: { width, height },
-    extraHTTPHeaders: {
-      Authorization: `Bearer ${cred.token}`,
-    },
   });
 
   const page = await context.newPage();
+  // Scope the auth header to the Paperclip origin only
+  await page.route(`${origin}/**`, (route) => {
+    route.continue({
+      headers: { ...route.request().headers(), Authorization: `Bearer ${cred.token}` },
+    });
+  });
   try {
     await page.goto(url, { waitUntil: "networkidle", timeout: 20000 });
     await page.waitForTimeout(waitMs);
@@ -79,7 +83,7 @@ const url = rawUrl.startsWith("http") ? rawUrl : `${cred.apiBase}${rawUrl}`;
     console.log(`Saved: ${outPath}`);
   } catch (err) {
     console.error(`Screenshot failed: ${err.message}`);
-    process.exit(1);
+    process.exitCode = 1;
   } finally {
     await browser.close();
   }