Jannik/PaperClipAI
1
0 Fork 0
mirror of https://github.com/paperclipai/paperclip.git synced 2026-10-17 10:06:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(computers): authorize scoped cleanup of previous viewers

Browse Source 
Preserve the full route regression suite in the stacked acceptance proof branch. Cleanup remains fenced by company, environment, current user, and exact owner generation.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
DottaandPaperclip committed 2026-10-10 16:18:01 -05:00
1 parent 5c3cd777df
commit 754a4e792e
2 files changed
+34 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

server/src/modules/computers/application/service.test.ts
+24
View File
@@ -298,6 +298,30 @@ describe("computer ownership", () => {
await f.service.reconcile();
expect(f.backend.stop).toHaveBeenCalledOnce();
});
it("disconnects only the exact company-scoped viewer owned by the current user without provider access", async () => {
const f = fixture();
await f.attach();
const viewer = await f.service.connect({ ...f.scope, userId: "alice", idleTimeoutMs: 60_000 });
const other = await f.service.connect({ ...f.scope, userId: "bob", idleTimeoutMs: 60_000 });
const runner = await f.admit();
vi.clearAllMocks();
const input = { ...f.scope, owner: viewer.owner, userId: "alice" };
await expect(f.service.disconnectViewer({ ...input, companyId: "foreign-company" })).rejects.toMatchObject({ code: "not_found" });
await expect(f.service.disconnectViewer({ ...input, environmentId: "foreign-environment" })).rejects.toMatchObject({ code: "not_found" });
await expect(f.service.disconnectViewer({ ...input, userId: "bob" })).rejects.toMatchObject({ code: "forbidden" });
await expect(f.service.disconnectViewer({ ...input, owner: { ...viewer.owner, generation: viewer.owner.generation + 1 } })).rejects.toMatchObject({ code: "conflict" });
await expect(f.service.disconnectViewer({ ...input, owner: { ...viewer.owner, computerId: "another-computer" } })).rejects.toMatchObject({ code: "conflict" });
await expect(f.service.disconnectViewer({ ...input, owner: runner.owner })).rejects.toMatchObject({ code: "forbidden" });
expect((await f.repository.get(f.scope)).ledger.owners.every(owner => owner.phase === "active")).toBe(true);
await f.service.disconnectViewer(input);
const owners = (await f.repository.get(f.scope)).ledger.owners;
expect(owners.find(owner => owner.id === viewer.owner.ownerId)?.phase).toBe("retired");
expect(owners.find(owner => owner.id === other.owner.ownerId)?.phase).toBe("active");
expect(owners.find(owner => owner.id === runner.owner.ownerId)?.phase).toBe("active");
for (const method of [f.backend.inspect, f.backend.ready, f.backend.retire, f.backend.stop, f.backend.renew, f.backend.desktop]) {
expect(method).not.toHaveBeenCalled();
}
});
it("prunes retired viewers while preserving active viewers and runner stop proof", async () => {
const f = fixture();
await f.attach();