From 74e54b713bcb74b6eaa2656ffd760bd57476bf85 Mon Sep 17 00:00:00 2001 From: Dotta Date: Fri, 9 Oct 2026 02:16:33 -0500 Subject: [PATCH] test(server): load feedback routes within suite setup Co-Authored-By: Paperclip --- server/src/__tests__/issue-feedback-routes.test.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/server/src/__tests__/issue-feedback-routes.test.ts b/server/src/__tests__/issue-feedback-routes.test.ts index e59fe6d1e9..2260676d6f 100644 --- a/server/src/__tests__/issue-feedback-routes.test.ts +++ b/server/src/__tests__/issue-feedback-routes.test.ts @@ -1,6 +1,6 @@ import express from "express"; import request from "supertest"; -import { beforeEach, describe, expect, it, vi } from "vitest"; +import { beforeAll, beforeEach, describe, expect, it, vi } from "vitest"; const mockFeedbackService = vi.hoisted(() => ({ getFeedbackTraceById: vi.fn(), @@ -127,11 +127,19 @@ vi.mock("../services/instance-settings.js", () => ({ instanceSettingsService: () => mockInstanceSettingsService, })); -async function createApp(actor: Record) { - const [{ issueRoutes }, { errorHandler }] = await Promise.all([ +let issueRoutes: typeof import("../routes/issues.js")["issueRoutes"]; +let errorHandler: typeof import("../middleware/index.js")["errorHandler"]; + +beforeAll(async () => { + // Route initialization belongs to the suite's setup deadline. The vote and + // flush assertions retain the ordinary per-test request deadline on CI. + [{ issueRoutes }, { errorHandler }] = await Promise.all([ import("../routes/issues.js"), import("../middleware/index.js"), ]); +}); + +async function createApp(actor: Record) { const app = express(); app.use(express.json()); app.use((req, _res, next) => {