From 57509a283ba5eeec223df1748d4840fb022b6c82 Mon Sep 17 00:00:00 2001 From: Dotta Date: Wed, 4 Nov 2026 09:22:31 -0600 Subject: [PATCH] chore(evals): remove added shared credential comments Preserve baseline comments and executable source while following the contribution requirements. Co-Authored-By: Paperclip --- tests/runner-e2e/chat-catalog-contract.ts | 6 +----- .../chat-catalog-domains/external-secret-question.ts | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/runner-e2e/chat-catalog-contract.ts b/tests/runner-e2e/chat-catalog-contract.ts index f4df4bc6f21..7519ab6a476 100644 --- a/tests/runner-e2e/chat-catalog-contract.ts +++ b/tests/runner-e2e/chat-catalog-contract.ts @@ -195,11 +195,8 @@ export interface ChatCatalogCase { /** Known missing catalog conditions keep this executable diagnostic case from acceptance. */ coverageGaps?: readonly string[]; expectedRunCount: number; - /** Persisted human comments by default. The two credential cases may count one - * independently verified UI question answer as a declared human action instead - * of a followup comment; raw comment/query evidence is never rewritten. */ + /** Persisted human comments; explicit followups must be declared before execution. */ expectedHumanMessageCount?: number; - /** Only company/personal secure-entry cases; returns identity after full case proof, never authority. */ expectedHumanQuestionAnswer?(observation: unknown): ChatCatalogExpectedHumanQuestionAnswer | undefined; /** Genuine persisted human setup turns before the canonical query; included in the total above. */ setupHumanMessageCount?: number; @@ -261,7 +258,6 @@ export interface ChatCatalogHumanQuestionAudit { companyId?: string; entityId?: string; action?: string; actorType?: string; actorId?: string; details?: Record | null; } -/** Verify public resolver facts independently of the case's proposed identity. */ export function verifyChatCatalogHumanQuestionAnswer(input: { expected: ChatCatalogExpectedHumanQuestionAnswer; companyId: string; issueId: string; agentId: string; canonicalComment: { id: string; authorUserId?: string }; diff --git a/tests/runner-e2e/chat-catalog-domains/external-secret-question.ts b/tests/runner-e2e/chat-catalog-domains/external-secret-question.ts index 1265e067571..3c2594e7f9a 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-secret-question.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-secret-question.ts @@ -5,7 +5,6 @@ import { askUserQuestionsPayloadSchema } from "../../../packages/shared/src/vali export interface SecretQuestionBinding { companyId: string; issueId: string; agentId: string; userId: string; runId: string; } -/** Structural admission only. Each credential journey owns its intent and saved-value proof. */ export function boundSecretQuestion(value: unknown, b: SecretQuestionBinding, status: "pending" | "answered" = "pending") { const row = value as Partial | undefined; if (!row || typeof row.id !== "string" || row.kind !== "ask_user_questions" || row.status !== status