Jannik/PaperClipAI
1
0 Fork 0
mirror of https://github.com/paperclipai/paperclip.git synced 2026-10-21 08:22:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(skills): separate audit deadline from process startup (#16610)

Browse Source
This commit is contained in:
Nicky Leach authored and GitHub committed 2026-10-16 15:52:54 -07:00
1 parent 9a3290fe10
commit 564d4e1bce
1 file changed
+37 -10
Download Patch File Download Diff File Expand all files Collapse all files
server/src/__tests__/github-skill-source.test.ts
+37 -10
View File
@@ -1,10 +1,10 @@
import { githubFixture } from "./helpers/github-skills.js";
import { execFile } from 'node:child_process';
import { fork } from 'node:child_process';
import { once } from 'node:events';
import { promises as fs } from 'node:fs';
import os from 'node:os';
import path from 'node:path';
import { pathToFileURL } from 'node:url';
import { promisify } from 'node:util';
import { describe, expect, it, vi } from 'vitest';
import { scanGitHubSkills, scanGitHubSkillsWithPackageFallback, previewGitHubSkillFile, parseSkillRepository } from '../services/github-skill-source.js';
import { skillSourceDiscoverySchema, skillSourcePreviewSchema, type SkillSourceScanUpdate } from '@paperclipai/shared';
@@ -490,17 +490,44 @@ describe('repository packages', () => {
const service = pathToFileURL(path.resolve(import.meta.dirname, '../services/company-skills.ts')).href;
const loader = path.resolve(import.meta.dirname, '../../../cli/node_modules/tsx/dist/loader.mjs');
const script = `import { auditSkillSnapshot } from ${JSON.stringify(service)};
const findings = await auditSkillSnapshot([
{ path: 'scripts/newlines.sh', kind: 'script', content: '\\n'.repeat(1024 * 1024 - 1) + 'x' },
{ path: 'scripts/spaces.sh', kind: 'script', content: 'then' + ' '.repeat(1024 * 1024 - 5) + 'x' },
], false);
console.log(JSON.stringify(findings));`;
const { stdout } = await promisify(execFile)(process.execPath, ['--import', loader, '--input-type=module', '-e', script], {
timeout: 10_000, killSignal: 'SIGKILL', encoding: 'utf8', env: { ...process.env, TMPDIR: scratch },
process.once('message', async () => {
try {
const findings = await auditSkillSnapshot([
{ path: 'scripts/newlines.sh', kind: 'script', content: '\\n'.repeat(1024 * 1024 - 1) + 'x' },
{ path: 'scripts/spaces.sh', kind: 'script', content: 'then' + ' '.repeat(1024 * 1024 - 5) + 'x' },
], false);
console.log(JSON.stringify(findings));
} finally { process.disconnect(); }
});
process.send('ready');`;
const scriptPath = path.join(scratch, 'audit.mjs');
await fs.writeFile(scriptPath, script);
const child = fork(scriptPath, [], {
execArgv: ['--import', loader], silent: true, env: { ...process.env, TMPDIR: scratch },
});
let stdout = '';
let stderr = '';
child.stdout!.setEncoding('utf8').on('data', data => { stdout += data; });
child.stderr!.setEncoding('utf8').on('data', data => { stderr += data; });
let phase: 'startup' | 'audit' = 'startup';
let deadline = setTimeout(() => child.kill('SIGKILL'), 60_000);
child.once('message', message => {
if (message !== 'ready') return;
phase = 'audit';
clearTimeout(deadline);
deadline = setTimeout(() => child.kill('SIGKILL'), 10_000);
child.send('audit');
});
try {
const [code, signal] = await once(child, 'close');
expect({ phase, code, signal }, stderr).toEqual({ phase: 'audit', code: 0, signal: null });
} finally {
clearTimeout(deadline);
child.kill('SIGKILL');
}
expect(JSON.parse(stdout).filter((finding: { severity: string }) => finding.severity === 'error')).toEqual([]);
} finally {
await fs.rm(scratch, { recursive: true, force: true });
}
}, 15_000);
}, 75_000);
});