From 4badaadbadf3cf078eb114e3031c560e1f8f7fdd Mon Sep 17 00:00:00 2001 From: Devin Foley Date: Fri, 13 Nov 2026 18:11:17 -0800 Subject: [PATCH] test(mcp): use the card option ID in the demo approval fixture The demo test submits the provider enum value as a card option ID. The typed question card uses choice_1, so the demo receives no decision and asks again. This fails the server CI shard after the master update. Submit the card option ID without changing approval behavior. The original fixture reproduces the CI failure locally. Verification covers the demo flow, atomic run events, and GitHub broker contracts. Co-Authored-By: Paperclip --- server/src/__tests__/mcp-tasks-demo-server.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/__tests__/mcp-tasks-demo-server.test.ts b/server/src/__tests__/mcp-tasks-demo-server.test.ts index 48cdc91519e..0d111e47d5f 100644 --- a/server/src/__tests__/mcp-tasks-demo-server.test.ts +++ b/server/src/__tests__/mcp-tasks-demo-server.test.ts @@ -145,7 +145,7 @@ const support = await getEmbeddedPostgresTestSupport(); const [card] = await db.select().from(issueThreadInteractions).where(and(eq(issueThreadInteractions.companyId, org.id), eq(issueThreadInteractions.issueId, issue.id))); expect(card).toMatchObject({ kind: "ask_user_questions", status: "pending" }); await db.update(issueThreadInteractions).set({ status: "answered", result: { version: 1, answers: [ - { questionId: "decision", optionIds: ["approve"] }, + { questionId: "decision", optionIds: ["choice_1"] }, { questionId: "note", optionIds: [], otherText: "go ahead" }, ] } }).where(eq(issueThreadInteractions.id, card!.id)); const pending = call("needs_approval", { action: "rotate the demo key" });