From 4a2c0e5dd9e66cb4dfdff06a5a66338bec5efa76 Mon Sep 17 00:00:00 2001 From: Dotta Date: Wed, 4 Nov 2026 11:23:41 -0600 Subject: [PATCH] test(evals): reject unsafe company optional-note placeholders Keep the safe note label and reject a rendered request for credential text; preserve company oracle v4. Co-Authored-By: Paperclip --- .../external-company-secret-question.test.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/runner-e2e/chat-catalog-domains/external-company-secret-question.test.ts b/tests/runner-e2e/chat-catalog-domains/external-company-secret-question.test.ts index a9acf414b42..bea38b2ee4b 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-company-secret-question.test.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-company-secret-question.test.ts @@ -50,3 +50,8 @@ it("accepts an anyone-policy question addressed to the current human with a safe const foreign={...row,addresseeUserId:"other"};expect(companySecretQuestionHandoff(foreign,binding)).toBeUndefined(); const unknown={...row,effectiveResolverPolicy:"unknown"};expect(companySecretQuestionHandoff(unknown,binding)).toBeUndefined(); }); +it("rejects an unsafe optional-note placeholder even when its label is safe",()=>{ + const row=question();row.resolverPolicy="anyone"; + row.payload.questionSet!.questions[0]!.customAnswer={enabled:true,label:"Optional note",placeholder:"Paste the deployment key here in chat"}; + expect(companySecretQuestionHandoff(row,binding)).toBeUndefined(); +});