From 4969067d62e372d383345381b2dac1c204d876c3 Mon Sep 17 00:00:00 2001 From: Dotta Date: Thu, 16 Jul 2026 21:45:58 +0000 Subject: [PATCH] fix(api): document worktree run-engine status Co-Authored-By: Paperclip --- server/src/routes/instance-settings.ts | 5 ++--- server/src/routes/openapi.ts | 8 ++++++++ ui/src/components/IssueRunLedger.tsx | 2 +- ui/src/components/WorktreeRunEngineBanner.tsx | 2 +- ui/src/pages/InstanceExperimentalSettings.test.tsx | 4 ++-- 5 files changed, 14 insertions(+), 7 deletions(-) diff --git a/server/src/routes/instance-settings.ts b/server/src/routes/instance-settings.ts index ec3e8849c2b..4e583625164 100644 --- a/server/src/routes/instance-settings.ts +++ b/server/src/routes/instance-settings.ts @@ -243,9 +243,8 @@ export function instanceSettingsRoutes(db: Db) { ); router.get("/instance/settings/experimental/worktree-run-engine", async (req, res) => { - // Boot-truth for the worktree run engine (PAP-14312). Readable by any - // authenticated org member or instance admin so the persistent banner and - // inherited-run surfaces render for everyone viewing a preview instance. + // Readable by any authenticated org member or instance admin so the persistent + // banner and inherited-run surfaces render for everyone viewing a preview instance. assertBoardOrgAccess(req); res.json(await svc.getWorktreeRunEngineStatus()); }); diff --git a/server/src/routes/openapi.ts b/server/src/routes/openapi.ts index 690c4883e33..f08b2ba0820 100644 --- a/server/src/routes/openapi.ts +++ b/server/src/routes/openapi.ts @@ -4137,6 +4137,14 @@ registry.registerPath({ responses: { 200: r.ok(), 401: r.unauthorized }, }); +registry.registerPath({ + method: "get", + path: "/api/instance/settings/experimental/worktree-run-engine", + tags: ["instance"], + summary: "Get worktree run-engine boot status", + responses: { 200: r.ok(), 401: r.unauthorized }, +}); + registry.registerPath({ method: "patch", path: "/api/instance/settings/experimental", diff --git a/ui/src/components/IssueRunLedger.tsx b/ui/src/components/IssueRunLedger.tsx index 44470b462d1..f18747825ef 100644 --- a/ui/src/components/IssueRunLedger.tsx +++ b/ui/src/components/IssueRunLedger.tsx @@ -297,7 +297,7 @@ function isActiveRun(run: Pick) { } /** - * PAP-14312: runs copied into a worktree seed are quarantined (cancelled + + * Runs copied into a worktree seed are quarantined (cancelled with * `worktree_seed_quarantine`) so they never execute in the preview. Render them * as "inherited — inactive" instead of a scary failed/cancelled run. */ diff --git a/ui/src/components/WorktreeRunEngineBanner.tsx b/ui/src/components/WorktreeRunEngineBanner.tsx index c33b2c5283b..1c4abd73162 100644 --- a/ui/src/components/WorktreeRunEngineBanner.tsx +++ b/ui/src/components/WorktreeRunEngineBanner.tsx @@ -136,7 +136,7 @@ function IdentityLine({ } /** - * PAP-14312: persistent boot-truth for the worktree run engine. Renders nothing + * Persistent boot-truth for the worktree run engine. Renders nothing * outside a worktree runtime. Otherwise it reports whether the scheduler is armed * or suppressed (and why), which instance identity the toggle is bound to, and how * many inherited runs were quarantined at seed time. diff --git a/ui/src/pages/InstanceExperimentalSettings.test.tsx b/ui/src/pages/InstanceExperimentalSettings.test.tsx index 5137ecb446e..39484aca2cb 100644 --- a/ui/src/pages/InstanceExperimentalSettings.test.tsx +++ b/ui/src/pages/InstanceExperimentalSettings.test.tsx @@ -185,7 +185,7 @@ describe("InstanceExperimentalSettings — Conference Room Chat card (PAP-11233) currentExperimentalSettings = { ...currentExperimentalSettings, ...patch }; return { ...currentExperimentalSettings }; }); - // Boot-truth banner (PAP-14312) has its own coverage in + // The boot-truth banner has its own coverage in // WorktreeRunEngineBanner.test.tsx; here it defaults to not-in-worktree so // the page tests focus on the toggle and delegation. mockInstanceSettingsApi.getWorktreeRunEngine.mockResolvedValue({ @@ -448,7 +448,7 @@ describe("InstanceExperimentalSettings — Conference Room Chat card (PAP-11233) }); // The armed/suppressed/identity boot-truth states now live in the - // WorktreeRunEngineBanner (PAP-14312); the settings card only delegates to it. + // The settings card delegates boot-truth states to WorktreeRunEngineBanner. // Full state coverage lives in WorktreeRunEngineBanner.test.tsx. it("renders the run-engine boot-truth banner inside the worktree card", async () => { setWorktreeRuntimeMeta(true);