mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-22 03:29:18 +01:00
style: remove comments from retry admission fix
Follow the contribution rule against new code comments. Keep the explanation in the pull request description and retain the existing test names. Only four full-line comments were removed. No executable code changed. The saved-work retry suite passed all 15 tests again. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
1 parent
6fda716f43
commit
3f7cd590aa
2 files changed
-4
No files matched your search
@@ -48,9 +48,6 @@ export async function isFailedNativePreparationRetryAncestor(db: Db, run: Run, c
|
||||
async function failedNativePreparation(db: Db, run: Run, coordinator: Coordinator | undefined, historicalRetryAncestor: boolean) {
|
||||
if (!historicalRetryAncestor && !coordinator && await isInterruptedNativePreparation(db, run)) return true;
|
||||
const recovery = run.resultJson?.executionRecovery as Record<string, unknown> | undefined;
|
||||
// Older preparers used adapter_failed before provider dispatch. Apply the
|
||||
// same full stop, host-log and saved-file proof whether that run is the
|
||||
// latest Retry source or an ancestor behind a never-started recovery turn.
|
||||
const historicalEvidence = historicalRetryAncestor || run.errorCode === "adapter_failed";
|
||||
const preparationFailure = run.errorCode === "setup_failed" || run.errorCode === "adapter_failed";
|
||||
if (run.status !== "failed" || !run.finishedAt || run.runtimeMode !== "legacy" || run.runtimeModeResolvedAt
|
||||
|
||||
@@ -277,7 +277,6 @@ describe("Retry of a task whose saved work recovery settled", () => {
|
||||
|
||||
it("admits Retry when the latest run is the verified legacy adapter preparation itself", async () => {
|
||||
const f = await sourceUnavailable({ heldRun: false });
|
||||
// Occupy the worker so this proves admission without starting a provider.
|
||||
await db.insert(heartbeatRuns).values({ companyId: f.companyId, agentId: f.agentId, status: "running" });
|
||||
const receipt = await requestTaskRetry({ db, companyId: f.companyId, issueId: f.issueId, actorId,
|
||||
observedRunId: f.preparedId, idempotencyKey: randomUUID(), actorSource: "local_implicit" });
|
||||
|
||||
Reference in new issue
Block a user