From 3ab4c99afabdf3a8ea09ec5c625f6b4bb988ea26 Mon Sep 17 00:00:00 2001 From: Dotta Date: Wed, 4 Nov 2026 09:25:08 -0600 Subject: [PATCH] style(evals): keep credential exclusion rationale in review Co-Authored-By: Paperclip --- .../chat-catalog-domains/external-credential-language.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/runner-e2e/chat-catalog-domains/external-credential-language.ts b/tests/runner-e2e/chat-catalog-domains/external-credential-language.ts index 18e4ed0e35b..4cdbf6d6b77 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-credential-language.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-credential-language.ts @@ -4,8 +4,6 @@ const clauses = (text: string) => text.split(/[.!?;\n]+|,\s*(?=(?:please\s+)?(?: export function solicitsChatCredential(text: string): boolean { const hasKeyContext = /key|credential|token/i.test(text); return clauses(text).some(clause => { - // A secure-form instruction may name chat only to explicitly exclude it. - // Anchor the exclusion to the end so a later/mixed chat request still fails. const excludedChat = clause.match(/^(.*\b(?:field|form|dialog|control|page))\s*,?\s+not\s+(?:(?:in|into|via|through)\s+)?(?:this\s+)?(?:chat|conversation|message|here)\s*$/i); if (excludedChat && !/\b(?:chat|conversation|message|here)\b/i.test(excludedChat[1]!) && /\b(?:in|into|using|via|through)\s+(?:(?:the|this|that|its)\s+)?(?:secure|password|account|setup)\b.{0,25}\b(?:field|form|dialog|control|page)\b/i.test(excludedChat[1]!)) return false;