mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-10 12:37:55 +01:00
fix(slack): preserve explicit DM task controls
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
1 parent
78108efc0c
commit
367b6f9b3f
6 files changed
+33
-26
No files matched your search
@@ -654,12 +654,7 @@ retrieval or telephone playback is established by the UI fixtures.
|
||||
Slack's **Require at-mention** policy applies to channel messages and channel
|
||||
thread replies, including queued work. DMs are exempt from mention checks;
|
||||
endpoint availability, **Allow direct messages**, and sender authorization still
|
||||
apply. Top-level DM replies retain their linear conversation destination. Native
|
||||
DM threads retain their task across completion while keeping the `direct_message`
|
||||
resource type and the DM reach gate. Duplicate delivery does not add another
|
||||
comment or wake. These cases have PostgreSQL fixture coverage in the
|
||||
[chat integration suite](../../server/src/__tests__/chat-channels.integration.test.ts).
|
||||
Source:
|
||||
apply. Top-level DM replies retain their linear conversation destination. Source:
|
||||
[admission](../../server/src/services/chat-channels.ts) and
|
||||
[queued run policy](../../server/src/services/durable-chat-wakeup.ts). Live Slack
|
||||
verification of this exemption remains separate from provider-fixture coverage.
|
||||
|
||||
@@ -101,15 +101,9 @@ cover the database and prompt contracts; they do not prove live provider deliver
|
||||
|
||||
For Slack, enable **Require at-mention** and **Allow direct messages**. Send a
|
||||
plain DM and follow up without a mention: both should reach the agent, with
|
||||
top-level replies to top-level DMs. Channel messages and channel thread replies
|
||||
still require a mention when that setting is enabled. Finish a task inside a DM
|
||||
thread, then reply in that same thread. The reply must reopen the same task and
|
||||
retain its earlier comments. A different thread root must use a different task.
|
||||
Disable direct messages and confirm both plain and threaded DMs are rejected.
|
||||
The [completion regression](../../server/src/__tests__/chat-channels.integration.test.ts)
|
||||
covers Done, Cancelled, completed bindings, duplicate delivery, and bare-DM and
|
||||
channel-thread controls with PostgreSQL and provider fixtures. This is not live
|
||||
Slack verification.
|
||||
top-level replies to top-level DMs. Channel messages and channel thread replies still
|
||||
require a mention when that setting is enabled. Disable direct messages and
|
||||
confirm a plain DM is rejected. Threads also work in DMs.
|
||||
|
||||
For Slack acknowledgement latency, mention the bot with and without an attachment.
|
||||
Eyes should appear after authorized task/comment persistence, independently of
|
||||
|
||||
Reference in new issue
Block a user