From 3531d19002aead50e559658a9895e361378c4a66 Mon Sep 17 00:00:00 2001 From: Dotta Date: Sat, 6 Jun 2026 16:10:11 +0000 Subject: [PATCH] fix(auth): align alert live region semantics --- ui/src/pages/Auth.test.tsx | 2 +- ui/src/pages/Auth.tsx | 2 +- ui/src/pages/InviteLanding.test.tsx | 2 +- ui/src/pages/InviteLanding.tsx | 1 - 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/ui/src/pages/Auth.test.tsx b/ui/src/pages/Auth.test.tsx index 269e1f425a6..39682c34c30 100644 --- a/ui/src/pages/Auth.test.tsx +++ b/ui/src/pages/Auth.test.tsx @@ -188,7 +188,7 @@ describe("AuthPage", () => { const alert = container.querySelector('[role="alert"]') as HTMLElement; expect(alert).not.toBeNull(); - expect(alert.getAttribute("aria-live")).toBe("polite"); + expect(alert.hasAttribute("aria-live")).toBe(false); expect(alert.textContent).toContain("Invalid email or password"); const errorId = alert.id; diff --git a/ui/src/pages/Auth.tsx b/ui/src/pages/Auth.tsx index 04f668ed999..fc2f7a84fbc 100644 --- a/ui/src/pages/Auth.tsx +++ b/ui/src/pages/Auth.tsx @@ -158,7 +158,7 @@ export function AuthPage() { /> {error && ( - )} diff --git a/ui/src/pages/InviteLanding.test.tsx b/ui/src/pages/InviteLanding.test.tsx index 32c4201a035..c26174de7ea 100644 --- a/ui/src/pages/InviteLanding.test.tsx +++ b/ui/src/pages/InviteLanding.test.tsx @@ -320,7 +320,7 @@ describe("InviteLandingPage", () => { const alert = container.querySelector('[role="alert"]') as HTMLElement; expect(alert).not.toBeNull(); - expect(alert.getAttribute("aria-live")).toBe("polite"); + expect(alert.hasAttribute("aria-live")).toBe(false); const errorId = alert.id; expect(errorId.length).toBeGreaterThan(0); diff --git a/ui/src/pages/InviteLanding.tsx b/ui/src/pages/InviteLanding.tsx index 37ed48f3052..8c8eca5b31f 100644 --- a/ui/src/pages/InviteLanding.tsx +++ b/ui/src/pages/InviteLanding.tsx @@ -770,7 +770,6 @@ export function InviteLandingPage() {