From 33fa3d3d4c7988288685ce7c6499d064e0cb9079 Mon Sep 17 00:00:00 2001 From: Dotta Date: Fri, 6 Nov 2026 19:38:19 -0600 Subject: [PATCH] chore(skills): follow repository comment policy --- .../src/services/native-runtime/native-skill-library-tools.ts | 1 - server/src/services/skill-package-runtime.ts | 3 --- server/src/services/skill-package-store.ts | 2 -- 3 files changed, 6 deletions(-) diff --git a/server/src/services/native-runtime/native-skill-library-tools.ts b/server/src/services/native-runtime/native-skill-library-tools.ts index 03db8b30ce5..04cfc68f6c6 100644 --- a/server/src/services/native-runtime/native-skill-library-tools.ts +++ b/server/src/services/native-runtime/native-skill-library-tools.ts @@ -13,7 +13,6 @@ import { settleRunnerBridgeRead } from "./runner-bridge-tools.js"; const MAX_TEXT_FILE_BYTES = 16 * 1024 * 1024; type SkillText = { text: string; sha256: string; byteSize: number }; -/** Owned by one run authority. Retain at most 64 MiB of text and 64 entries. */ export class SkillLibraryReadCache { #entries = new Map(); #bytes = 0; diff --git a/server/src/services/skill-package-runtime.ts b/server/src/services/skill-package-runtime.ts index 79e94b26101..06695047f8a 100644 --- a/server/src/services/skill-package-runtime.ts +++ b/server/src/services/skill-package-runtime.ts @@ -38,8 +38,6 @@ function originalFiles(version: StoredSkillVersion, manifest: SkillPackageManife export function skillPackageRuntime(db: Db) { const store = skillPackageStore(db); function readOriginalFile(version: StoredSkillVersion, sourcePath: string, maxBytes?: number, projected?: ProjectedFile) { - // Use verified warm reads and isolated recovery, without the company-wide - // preparation lock. The projection has already resolved the source path. return store.readVersionFile({ ...version, packageSnapshotId: version.repositorySnapshotId ?? version.packageSnapshotId, packageFileMap: projected ? [{ path: sourcePath, sourcePath, kind: projected.kind, encoding: projected.encoding }] : null }, sourcePath, true, maxBytes); } @@ -119,7 +117,6 @@ export function skillPackageRuntime(db: Db) { async function readFile(version: StoredSkillVersion, relative: string, maxBytes?: number) { const id = (version.repositorySnapshotId ?? version.packageSnapshotId)!; const manifest = await store.manifest(version.companyId, id); - // Original references need no wrapper generation or entrypoint-body read. const file = originalFiles(version, manifest).find(file => file.path === relative) ?? (await projection(version, maxBytes)).find(file => file.path === relative); if (!file) return null; diff --git a/server/src/services/skill-package-store.ts b/server/src/services/skill-package-store.ts index 5f0f03a8a73..b88d9a8a55d 100644 --- a/server/src/services/skill-package-store.ts +++ b/server/src/services/skill-package-store.ts @@ -645,8 +645,6 @@ export function skillPackageStore(db: Db, suppliedStorage?: StorageService, cach async function readVersionFile(version: StoredSkillVersion, relativePath: string, allowRecovery = true, maxBytes = Number.MAX_SAFE_INTEGER) { assertSkillSnapshotPath(relativePath); if (!version.packageSnapshotId) { - // Select only the requested legacy file. Apply the bound in PostgreSQL so - // an oversized inline body never crosses into the server process. const [row] = await db.select({ ...skillVersionMetadataColumns, file: sql<(CompanySkillVersionFileInventoryEntry & { tooLarge?: boolean }) | null>`( select case when octet_length(f->>'content')::bigint > ${maxBytes}::bigint