Merge decision paging repairs into retention stack

Co-Authored-By: Paperclip <noreply@paperclip.ing>

* codex/sleep-13-grok-dispatch:
  fix(server): retain database precision in effect recovery cursor
  fix(server): preserve expiry paging timestamp precision
This commit is contained in:
DottaandPaperclip committed 2026-10-24 15:24:26 -07:00
commit 2c5babcabc
6 files changed
+66 -9

No files matched your search

@@ -14,14 +14,14 @@ function recoveryGraceMs() {
}
export function decisionEffectRecoveryService(db: Db, resume: (id: string) => Promise<boolean>) {
let cursor: { updatedAt: Date; id: string } | undefined;
let cursor: { updatedAt: string; id: string } | undefined;
async function sweep(now = new Date(), limit = decisionSweepBatchSize(), signal?: AbortSignal) {
let resumed = 0;
if (signal?.aborted) return { resumed };
const rows = await db.select({ id: decisions.id, updatedAt: decisions.updatedAt }).from(decisions)
const rows = await db.select({ id: decisions.id, updatedAt: sql<string>`${decisions.updatedAt}::text` }).from(decisions)
.where(and(running, lte(decisions.updatedAt, new Date(now.getTime() - recoveryGraceMs())), cursor
? sql`(${decisions.updatedAt}, ${decisions.id}) > (${cursor.updatedAt.toISOString()}::timestamptz, ${cursor.id}::uuid)` : undefined))
? sql`(${decisions.updatedAt}, ${decisions.id}) > (${cursor.updatedAt}::timestamptz, ${cursor.id}::uuid)` : undefined))
.orderBy(asc(decisions.updatedAt), asc(decisions.id)).limit(limit);
const errors: unknown[] = [];
for (const row of rows) {
+7 -6
View File
@@ -1,4 +1,4 @@
import { and, asc, eq, lte, sql } from "drizzle-orm";
import { and, asc, eq, getTableColumns, lte, sql } from "drizzle-orm";
import { decisions, type Db } from "@paperclipai/db";
import { logActivity } from "./activity-log.js";
import { writeDecisionChange } from "./decision-work-notifications.js";
@@ -8,7 +8,7 @@ type ExpiryReason = "ttl" | "target_gone" | "target_completed";
const open = sql`${decisions.status} = 'open'`;
export function decisionExpiryService(db: Db, deliverContinuation: (id: string) => Promise<void>) {
let recoveryCursor: { expiresAt: Date; id: string } | undefined;
let recoveryCursor: { expiresAt: string; id: string } | undefined;
async function expire(decision: Decision, reason: ExpiryReason, now: Date) {
const [updated] = await writeDecisionChange(db, async tx => tx.update(decisions).set({
status: "expired", updatedAt: now,
@@ -24,9 +24,10 @@ export function decisionExpiryService(db: Db, deliverContinuation: (id: string)
return 1;
}
async function due(now: Date, limit: number, cursor?: { expiresAt: Date; id: string }) {
return db.select().from(decisions).where(and(open, lte(decisions.expiresAt, now), cursor
? sql`(${decisions.expiresAt}, ${decisions.id}) > (${cursor.expiresAt.toISOString()}::timestamptz, ${cursor.id}::uuid)` : undefined))
async function due(now: Date, limit: number, cursor?: { expiresAt: string; id: string }) {
return db.select({ ...getTableColumns(decisions), cursorExpiresAt: sql<string>`${decisions.expiresAt}::text` })
.from(decisions).where(and(open, lte(decisions.expiresAt, now), cursor
? sql`(${decisions.expiresAt}, ${decisions.id}) > (${cursor.expiresAt}::timestamptz, ${cursor.id}::uuid)` : undefined))
.orderBy(asc(decisions.expiresAt), asc(decisions.id)).limit(limit);
}
@@ -38,7 +39,7 @@ export function decisionExpiryService(db: Db, deliverContinuation: (id: string)
for (const row of rows) {
if (signal?.aborted) return { expired };
try { expired += await expire(row, "ttl", now); } catch (error) { errors.push(error); }
recoveryCursor = { expiresAt: row.expiresAt, id: row.id };
recoveryCursor = { expiresAt: row.cursorExpiresAt, id: row.id };
}
if (rows.length < 100) recoveryCursor = undefined;
if (errors.length === 1) throw errors[0];