diff --git a/tests/runner-e2e/chat-catalog-descriptors.json b/tests/runner-e2e/chat-catalog-descriptors.json index 3b5b747c1e8..6c7ce6a361a 100644 --- a/tests/runner-e2e/chat-catalog-descriptors.json +++ b/tests/runner-e2e/chat-catalog-descriptors.json @@ -5051,6 +5051,7 @@ "../../packages/paperclip-runner/src/protocol-actions/request-human-input.ts", "chat-catalog-domains/external-personal-secret.ts", "chat-catalog-domains/external-personal-secret-menu.ts", + "chat-catalog-domains/external-personal-secret-link.ts", "../../ui/src/pages/secrets/MyUserSecretsTab.tsx", "chat-catalog-domains/external-personal-secret-confirmation.ts", "chat-catalog-contract.ts", diff --git a/tests/runner-e2e/chat-catalog-domains/external-personal-secret-link.test.ts b/tests/runner-e2e/chat-catalog-domains/external-personal-secret-link.test.ts new file mode 100644 index 00000000000..d16cf5ac516 --- /dev/null +++ b/tests/runner-e2e/chat-catalog-domains/external-personal-secret-link.test.ts @@ -0,0 +1,67 @@ +import { chromium } from "@playwright/test"; +import { expect, it } from "vitest"; +import { followPersonalSecretReplyLink, supportedSecretSettingsLink } from "./external-personal-secret-link.js"; + +const origin = "https://paperclip.example", chat = `${origin}/COM/chat`, secrets = "/COM/company/settings/secrets"; +const definition = "b22dfafd-1bae-4d33-a072-7dfb2e5358f8", key = "PERSONAL_PUBLISHING_KEY"; + +it("accepts only this company's secrets settings as a link target", () => { + expect(supportedSecretSettingsLink(secrets, origin, "COM", definition)).toBe(origin + secrets); + expect(supportedSecretSettingsLink(`${secrets}?definition=${definition}`, origin, "COM", definition)).toBe(`${origin}${secrets}?definition=${definition}`); + for (const href of ["/OTHER/company/settings/secrets", "/COM/company/settings/other", `https://foreign.example${secrets}`, + `${secrets}?definition=other`, `${secrets}?tab=x`, `${secrets}#mine`, null]) { + expect(supportedSecretSettingsLink(href, origin, "COM", definition), String(href)).toBeUndefined(); + } +}); + +// The reply retained from the failed run: one turn rendered as two messages, with +// the settings link followed by punctuation (":" and ",") in rendered markdown. +const retained = `

Only you can set your own personal credential value — it's stored through your secure entry, not by an agent, and it must never be pasted into chat.

+

Open My secrets, find the personal publishing credential required by COM-1, and choose Set my value for that definition.

+

Set your personal publishing credential through My secrets: choose Set my value for the personal publishing credential required by COM-1.

`; + +it.skipIf(process.env.PAPERCLIP_CHAT_EVAL_SECRET_ROUTE_CANARY !== "1")("grades the rendered setup link by clicking it to the own-value entry, not by the reply's wording", async () => { + const browser = await chromium.launch({ headless: true, ...process.env.PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE ? { executablePath: process.env.PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE } : {} }); + const page = await browser.newPage(); + const ownEntry = (id: string, button = "Set value") => ``; + const scenarios: Array<{ name: string; reply: string; accepted?: true; entry?: string; secretsPage?: string; sheetKey?: string }> = [ + { name: "retained valid reply", reply: retained, accepted: true }, + { name: "link opening the definition's detail sheet", reply: `

Use this page.

`, accepted: true }, + { name: "definition link whose sheet shows another key", reply: `

Use this page.

`, sheetKey: "OTHER_KEY" }, + { name: "tab selected after the click", reply: retained, accepted: true, + secretsPage: `` }, + // Like the real single-page app: the settings route renders its tabs after navigation, on the company tab. + { name: "tabs rendered after navigation", reply: retained, accepted: true, + secretsPage: `
` }, + { name: "no link, only wording", reply: "

Open My secrets in Settings → Secrets and choose Set my value.

" }, + { name: "plain-text path, not a link", reply: `

Go to ${secrets}.

` }, + { name: "wrong company link", reply: '

Open My secrets.

' }, + { name: "foreign link", reply: `

Open My secrets.

` }, + { name: "wrong page link", reply: '

Open My secrets.

' }, + { name: "hidden link", reply: `

Setup details:

` }, + { name: "link reaches another definition", reply: retained, entry: ownEntry("other-definition") }, + { name: "link reaches no own-value entry", reply: retained, entry: "

Nothing to set.

" }, + ]; + try { + for (const scenario of scenarios) { + await page.unroute("**/*"); + await page.route("**/*", async route => { + const url = new URL(route.request().url()), path = url.pathname; + // Like the real page: a definition link opens that definition's detail sheet over the list. + const sheet = url.searchParams.get("definition") === definition + ? `
${scenario.sheetKey ?? key}
` : ""; + const body = path === secrets + ? sheet + (scenario.secretsPage ?? `${scenario.entry ?? ownEntry(definition)}`) + : `
${scenario.reply}
`; + await route.fulfill({ contentType: "text/html; charset=utf-8", body }); + }); + await page.goto(chat); + const proof = await followPersonalSecretReplyLink(page, { commentId: "final-reply", origin, prefix: "COM", definitionId: definition, definitionKey: key, timeout: 3_000 }); + if (scenario.accepted) expect(proof, scenario.name).toMatchObject({ commentId: "final-reply", reachedOwnValueEntry: true, definitionKey: key }); + else expect(proof, scenario.name).toBeUndefined(); + expect(page.url(), scenario.name).toBe(chat); + } + } finally { + await browser.close(); + } +}, 60_000); diff --git a/tests/runner-e2e/chat-catalog-domains/external-personal-secret-link.ts b/tests/runner-e2e/chat-catalog-domains/external-personal-secret-link.ts new file mode 100644 index 00000000000..aee336db2ac --- /dev/null +++ b/tests/runner-e2e/chat-catalog-domains/external-personal-secret-link.ts @@ -0,0 +1,99 @@ +import type { Locator, Page } from "@playwright/test"; + +/** + * Grade a personal-secret setup reply by its rendered link, never by its + * wording. The reply passes when its rendered message holds a visible link to + * this company's secrets settings and clicking that link, as a person would, + * reaches the current person's own-value entry for the required definition. + * The reply's wording is left to human review. + */ +export interface PersonalSecretReplyLinkProof { + commentId: string; + /** The rendered link's resolved target, as the person's click followed it. */ + route: string; + linkText: string; + reachedOwnValueEntry: true; + definitionKey: string; +} + +/** A rendered link target is supported only for this origin and company's secrets settings. */ +export function supportedSecretSettingsLink(href: string | null, origin: string, prefix: string, definitionId: string): string | undefined { + try { + const url = new URL(href ?? "", origin); + const query = [...url.searchParams.keys()]; + if (url.origin !== origin || url.username || url.password || url.hash) return; + if (url.pathname !== `/${prefix}/company/settings/secrets`) return; + if (query.some(key => key !== "definition") || url.searchParams.getAll("definition").length > 1) return; + if (url.searchParams.has("definition") && url.searchParams.get("definition") !== definitionId) return; + return url.href; + } catch { + return; + } +} + +async function visible(node: Locator, timeout: number): Promise { + if (await node.count() !== 1 || !await node.isVisible()) return false; + await node.scrollIntoViewIfNeeded({ timeout }); + return node.evaluate(element => { + const rect = element.getBoundingClientRect(); + if (!element.checkVisibility({ checkOpacity: true, checkVisibilityCSS: true }) || rect.width <= 0 || rect.height <= 0 + || rect.bottom <= 0 || rect.top >= innerHeight || rect.right <= 0 || rect.left >= innerWidth) return false; + for (let parent = element.parentElement; parent; parent = parent.parentElement) { + const style = getComputedStyle(parent), box = parent.getBoundingClientRect(); + if (/hidden|clip/.test(style.overflowX) && (rect.right <= box.left || rect.left >= box.right)) return false; + if (/hidden|clip/.test(style.overflowY) && (rect.bottom <= box.top || rect.top >= box.bottom)) return false; + } + return true; + }); +} + +/** + * Find the visible supported link in the rendered reply, click it, and prove + * the click reached the own-value entry ("Set value" on the definition's row in + * My secrets). Returns to the conversation afterwards. Undefined when the reply + * has no such link or the click does not reach the entry. + */ +export async function followPersonalSecretReplyLink(page: Page, input: { + commentId: string; origin: string; prefix: string; definitionId: string; definitionKey: string; timeout: number; +}): Promise { + const deadline = Date.now() + input.timeout; + const remaining = () => { + const ms = deadline - Date.now(); + if (ms <= 0) throw new Error("Personal secret reply link deadline exceeded"); + return ms; + }; + const comment = page.locator(`[id=${JSON.stringify(`comment-${input.commentId}`)}]`); + await comment.waitFor({ state: "visible", timeout: remaining() }).catch(() => undefined); + if (!await comment.isVisible()) return; + let chosen: { anchor: Locator; route: string; text: string } | undefined; + for (const anchor of await comment.locator("a[href]").all()) { + const route = supportedSecretSettingsLink(await anchor.getAttribute("href"), input.origin, input.prefix, input.definitionId); + if (route && await visible(anchor, remaining())) { chosen = { anchor, route, text: (await anchor.innerText()).trim() }; break; } + } + if (!chosen) return; + const original = page.url(); + try { + await chosen.anchor.click({ timeout: remaining() }); + await page.waitForURL(url => url.origin === input.origin && url.pathname === new URL(chosen!.route).pathname, { timeout: remaining() }); + let entry: Locator; + if (new URL(chosen.route).searchParams.get("definition") === input.definitionId) { + // A link naming the definition opens its detail sheet, whose own-value action is "Set my value". + const sheet = page.locator('[data-testid="secret-details"]').filter({ has: page.getByText(input.definitionKey, { exact: true }) }); + entry = sheet.getByRole("button", { name: "Set my value", exact: true }); + } else { + const tab = page.getByRole("tab", { name: "My secrets", exact: true }); + await tab.waitFor({ state: "visible", timeout: remaining() }).catch(() => undefined); + if (await tab.count() === 1 && await tab.getAttribute("aria-selected") !== "true") await tab.click({ timeout: remaining() }); + // The row is bound to the required definition by its identity, and shows its key. + const row = page.locator(`[data-testid=${JSON.stringify(`my-secret-${input.definitionId}`)}]`) + .filter({ has: page.getByText(input.definitionKey, { exact: true }) }); + entry = row.getByRole("button", { name: "Set value", exact: true }); + } + await entry.waitFor({ state: "visible", timeout: remaining() }).catch(() => undefined); + if (Date.now() >= deadline || !await visible(entry, remaining())) return; + return { commentId: input.commentId, route: chosen.route, linkText: chosen.text, reachedOwnValueEntry: true, definitionKey: input.definitionKey }; + } finally { + // Returning to the conversation has its own bound so a failed check still restores the page. + if (page.url() !== original) await page.goto(original, { waitUntil: "domcontentloaded", timeout: 15_000 }); + } +} diff --git a/tests/runner-e2e/chat-catalog-domains/external-personal-secret-original-deadline.test.ts b/tests/runner-e2e/chat-catalog-domains/external-personal-secret-original-deadline.test.ts index c2c8ccd5752..a7ec40b4cea 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-personal-secret-original-deadline.test.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-personal-secret-original-deadline.test.ts @@ -1,17 +1,20 @@ import { afterEach, expect, it, vi } from "vitest"; import type { ChatCatalogContext } from "../chat-catalog-contract.js"; -const port = vi.hoisted(() => ({ observation: {} as Record })); +const port = vi.hoisted(() => ({ observation: {} as Record, linked: true })); +// The rendered-link follower is a browser step with its own test; here it only reports whether the reply had a link. +vi.mock("./external-personal-secret-link.js", () => ({ followPersonalSecretReplyLink: async (_page: unknown, input: { commentId: string }) => port.linked + ? { commentId: input.commentId, route: "http://paperclip.test/ACORN/company/settings/secrets", linkText: "My secrets", reachedOwnValueEntry: true, definitionKey: "PERSONAL_PUBLISHING_KEY" } : undefined })); vi.mock("../codex-subscription-fixture.js", () => ({ codexSubscriptionAgentConfig: (value: unknown) => value })); vi.mock("./external-support.js", async original => ({ ...await original(), observeExternal: async () => port.observation })); import { personalSecretExternalCases } from "./external-personal-secret.js"; afterEach(() => { vi.useRealTimers(); vi.restoreAllMocks(); }); const start = 10_000, deadline = start + 630_000; -type Fault = "failed" | "cancelled" | "foreign actor" | "foreign company" | "foreign source" | "foreign task context" | "foreign comment" | "foreign person" | "foreign reply" | "no-secret-question" | "no work" | "late read"; +type Fault = "failed" | "cancelled" | "foreign actor" | "foreign company" | "foreign source" | "foreign task context" | "foreign comment" | "foreign person" | "foreign reply" | "no-settings-link" | "no work" | "late read"; function fixture(fault?: Fault, budget: number | "missing" = deadline) { vi.useFakeTimers(); vi.setSystemTime(start); let reachedHumanPhase = false; const query = "Set up my personal publishing credential for this task."; - const body = fault === "no-secret-question" ? "Which project should I work on?" : "Open secure My secrets settings and set your own personal publishing value. Never paste your key here."; + const body = fault === "no-settings-link" ? "Which project should I work on?" : "Open secure My secrets settings and set your own personal publishing value. Never paste your key here."; const run = { id: "initial", companyId: fault === "foreign company" ? "foreign" : "company", agentId: fault === "foreign actor" ? "morgan" : "ceo", runtimeMode: "native", status: "succeeded", contextSnapshot: { issueId: fault === "foreign source" ? "foreign" : "source", ...(fault === "foreign task context" ? { taskId: "foreign" } : {}), commentId: fault === "foreign comment" ? "foreign" : "human" } }; const comments = [{ id: "human", companyId: "company", issueId: "source", authorUserId: fault === "foreign person" ? "riley" : "person", body: query }, @@ -19,12 +22,13 @@ function fixture(fault?: Fault, budget: number | "missing" = deadline) { const source = { id: "source", companyId: "company", conversationState: "waiting" }; const allRuns = async () => fault === "no work" ? [] : [{ ...run, status: fault === "failed" || fault === "cancelled" ? fault : Date.now() < (fault ? start : start + 190_000) ? "running" : "succeeded" }]; const ctx = { ...(budget === "missing" ? {} : { observationDeadlineAt: budget }), scenario: { id: "secrets.personal-secret", query }, - input: { fixtures: { company: { id: "company", issuePrefix: "ACORN" }, agent: { id: "ceo" } }, api: { get: async (path: string) => { + input: { evidence: async () => {}, fixtures: { company: { id: "company", issuePrefix: "ACORN" }, agent: { id: "ceo" } }, api: { get: async (path: string) => { if (path === "/api/issues/source/comments?order=asc") { if (fault === "late read") vi.setSystemTime(deadline + 1); return comments; } if (path === "/api/companies/company/me/user-secrets") { reachedHumanPhase = true; throw Error("NEXT_REAL_HUMAN_PHASE"); } throw Error("Unexpected read"); } } }, issue: () => source, refreshIssue: async () => {}, allRuns, } as unknown as ChatCatalogContext; + port.linked = fault !== "no-settings-link"; port.observation = { companyId: "company", interactions: [], phaseReplies: [{ runId: fault === "foreign reply" ? "foreign" : "initial", commentId: "reply", body }], links: [] }; const state = { sourceIssueId: "source", currentPersonId: "person", definitionId: "definition" }; async function act(ms = 191_000) { @@ -38,7 +42,7 @@ it("actual personal-secret act admits the canonical native response after190s wi expect(error?.message).toBe("NEXT_REAL_HUMAN_PHASE"); expect(f.reachedHumanPhase()).toBe(true); expect(f.ctx.observationDeadlineAt).toBe(deadline); expect(personalSecretExternalCases[0]!.attemptTimeoutMs).toBe(660_000); }); -it.each(["failed", "cancelled", "foreign actor", "foreign company", "foreign source", "foreign task context", "foreign comment", "foreign person", "foreign reply", "no-secret-question", "late read"] as const)("rejects %s before private human entry", async fault => { +it.each(["failed", "cancelled", "foreign actor", "foreign company", "foreign source", "foreign task context", "foreign comment", "foreign person", "foreign reply", "no-settings-link", "late read"] as const)("rejects %s before private human entry", async fault => { const f = fixture(fault); expect(await f.act()).toBeInstanceOf(Error); expect(f.reachedHumanPhase()).toBe(false); }); it.each(["missing", NaN, Infinity, start, start - 1] as const)("rejects invalid or exhausted original deadline %s", async budget => { diff --git a/tests/runner-e2e/chat-catalog-domains/external-personal-secret.test.ts b/tests/runner-e2e/chat-catalog-domains/external-personal-secret.test.ts index 49b00e2b6aa..42760738429 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-personal-secret.test.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-personal-secret.test.ts @@ -58,6 +58,8 @@ function valid() { ], state: { initialRunId: "initial", + replyLinkProof: { commentId: "initial-reply", route: "http://paperclip.test/COM/company/settings/secrets", linkText: "My secrets", + reachedOwnValueEntry: true as const, definitionKey: "PERSONAL_PUBLISHING_KEY" } as Record | undefined, currentMissingBefore: true, requiredReferenceBefore: true, requiredReferenceAfter: true, @@ -153,9 +155,15 @@ it("rejects wrong owner/reference/consumer, premature success and missing/leakin (o: ReturnType) => { o.state.secretLeaked = true; }, + // The setup reply is graded by its followed link, not its wording. (o: ReturnType) => { - o.phaseReplies[0]!.body = - "Your personal publishing credential is now ready. Use secure settings."; + o.state.replyLinkProof = undefined; + }, + (o: ReturnType) => { + o.state.replyLinkProof = { ...o.state.replyLinkProof, commentId: "confirmed-reply" }; + }, + (o: ReturnType) => { + o.state.replyLinkProof = { ...o.state.replyLinkProof, reachedOwnValueEntry: false }; }, (o: ReturnType) => { o.runs[2]!.startedAt = "2026-11-04T00:00:05.000Z"; diff --git a/tests/runner-e2e/chat-catalog-domains/external-personal-secret.ts b/tests/runner-e2e/chat-catalog-domains/external-personal-secret.ts index 034c1ac2f95..99fd5bad0d0 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-personal-secret.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-personal-secret.ts @@ -2,6 +2,7 @@ import {personalSecretMenuNavigation,type PersonalSecretMenuNavigation} from "./ import { personalSecretConfirmationHandoff, acceptPersonalSecretConfirmation, confirmThenStartPersonalConsumer, readVisiblePersonalSecretConfirmation } from "./external-personal-secret-confirmation.js"; import type {Page} from "@playwright/test"; import {visibleSecretSettingsURL} from "./external-secret-route.js"; +import { followPersonalSecretReplyLink, type PersonalSecretReplyLinkProof } from "./external-personal-secret-link.js"; import { createHash, randomBytes } from "node:crypto"; import { expect } from "@playwright/test"; import type { AskUserQuestionsInteraction } from "../../../packages/shared/src/types/issue.js"; @@ -245,10 +246,7 @@ export function gradePersonalSecret(value: unknown) { "A required definition, real separate owners, secure UI entry and independently authenticated admitted worker check are required.", ); if (!o) return c.result(); - const initial = o.phaseReplies.find( - (row) => row.runId === o.state.initialRunId, - ), - questionRow = o.interactions.find(row => row.id === o.state.initialQuestionId), + const questionRow =o.interactions.find(row => row.id === o.state.initialQuestionId), question = personalSecretQuestionHandoff(questionRow, { companyId: o.companyId, issueId: String(o.state.sourceIssueId), agentId: o.leadId, userId: String(o.state.currentPersonId), runId: String(o.state.initialRunId), definitionId: String(o.state.definitionId) }, "answered"), questionAnswered = !!question && question.payloadHash === o.state.initialQuestionPayloadHash @@ -264,6 +262,11 @@ export function gradePersonalSecret(value: unknown) { const confirmation = personalSecretConfirmationHandoff(confirmationRow, { companyId: o.companyId, issueId: String(o.state.sourceIssueId), agentId: o.leadId, userId: String(o.state.currentPersonId), runId: String(o.state.initialRunId), definitionId: String(o.state.definitionId), canonicalCommentId: String(o.state.canonicalHumanCommentId) }, personalSecretGuidance, "accepted"); const confirmationAccepted = o.state.confirmationVisibleBeforeEntry === true && !!confirmation && confirmation.payloadHash === o.state.initialConfirmationPayloadHash && confirmation.continuationPolicy === o.state.initialConfirmationContinuationPolicy && o.activity.some(event => event.action === "issue.thread_interaction_accepted" && event.companyId === o.companyId && event.entityId === o.state.sourceIssueId && event.actorType === "user" && event.actorId === o.state.currentPersonId && event.details?.interactionId === confirmation.interactionId && event.details.interactionStatus === "accepted"); + // The reply is graded by its rendered link: clicking it reached the own-value entry for this definition. + const replyLink = o.state.replyLinkProof as PersonalSecretReplyLinkProof | undefined; + // A turn may post several messages; the graded link may be in any reply of the initial run. + const replyLinkReached = replyLink?.reachedOwnValueEntry === true + && o.phaseReplies.some(row => row.runId === o.state.initialRunId && row.commentId === replyLink.commentId); const secret = o.state.currentSecret as Partial | undefined; c.add( "missing-own-required-credential-and-truthful-handoff", @@ -271,7 +274,7 @@ export function gradePersonalSecret(value: unknown) { o.state.requiredReferenceBefore === true && o.state.otherConfiguredBefore === true && o.state.currentPersonId !== o.state.otherPersonId && - ((!!initial && personalSecretGuidance(initial.body)) || questionAnswered || confirmationAccepted) && + (replyLinkReached || questionAnswered || confirmationAccepted) && o.state.agentValueCreateStatus === 403, "Another person's real stored value does not satisfy the current person's required publishing definition, and chat directs secure own-value entry before claiming completion.", ); @@ -499,6 +502,7 @@ export const personalSecretExternalCases = [ "../../packages/paperclip-runner/src/protocol-actions/request-human-input.ts", "chat-catalog-domains/external-personal-secret.ts", "chat-catalog-domains/external-personal-secret-menu.ts", + "chat-catalog-domains/external-personal-secret-link.ts", "../../ui/src/pages/secrets/MyUserSecretsTab.tsx", "chat-catalog-domains/external-personal-secret-confirmation.ts", "chat-catalog-contract.ts", @@ -631,7 +635,7 @@ export const personalSecretExternalCases = [ const commentHandoff = !!reply && reply.runId === run.id && comments.some(comment => comment.id === reply.commentId && comment.companyId === source.companyId && comment.issueId === source.id && comment.authorAgentId === run.agentId && comment.createdByRunId === run.id - && comment.body?.trim() === reply.body.trim()) && personalSecretGuidance(reply.body); + && comment.body?.trim() === reply.body.trim()); if (initial.companyId !== source.companyId || (pendingQuestions.length ? !question && !confirmation : !commentHandoff)) throw new Error("Personal setup must direct the current person's secure publishing value before human action"); state.initialRunId = run.id; @@ -643,6 +647,22 @@ export const personalSecretExternalCases = [ } if (question) Object.assign(state, { initialQuestionId: question.interactionId, initialQuestionOptionId: question.optionId, initialQuestionPayloadHash: question.payloadHash }); + const path = `/${ctx.input.fixtures.company.issuePrefix}/company/settings/secrets`, + // Graded by its rendered link, followed as a person would; wording is left to human review. + // A question or confirmation card already carries the handoff, so a reply link is then optional. + replyLink = !question && !confirmation && commentHandoff && reply?.commentId ? await followPersonalSecretReplyLink(ctx.input.page, { + commentId: reply.commentId, origin: initial.origin, prefix: String(ctx.input.fixtures.company.issuePrefix), + definitionId: String(state.definitionId), definitionKey: "PERSONAL_PUBLISHING_KEY", timeout: remaining(), + }) : undefined, + link = replyLink?.route; + if (replyLink) { + state.replyLinkProof = replyLink; + await ctx.input.evidence("personal-secret-reply-link.json", replyLink); + } + if (!link && !question && !confirmation) + throw new Error( + "Actual reply must link to the current person's own-value entry for this definition", + ); if ( ( await ctx.input.api.get(`${root(ctx)}/me/user-secrets`) @@ -651,22 +671,15 @@ export const personalSecretExternalCases = [ throw new Error( "Current person's value was created before secure human entry", ); - const path = `/${ctx.input.fixtures.company.issuePrefix}/company/settings/secrets`, - link = commentHandoff ? await personalSecretSetupURL(ctx.input.page,reply!,initial.origin,String(ctx.input.fixtures.company.issuePrefix),String(state.definitionId),remaining(),proof=>{state.personalMenuNavigation=proof;}) : undefined; - if (!link && !question && !confirmation) - throw new Error( - "Actual reply must direct the supported own-value settings path for this definition", - ); - if(state.personalMenuNavigation)await ctx.input.evidence("personal-secret-menu-navigation.json",state.personalMenuNavigation); const url = new URL(question || confirmation ? path : link!, initial.origin); - if (!question && !confirmation && !state.personalMenuNavigation) url.searchParams.set("definition", String(state.definitionId)); + if (!question && !confirmation) url.searchParams.set("definition", String(state.definitionId)); const receipt = await privateBrowserEntry({ mode: "personal-secret-create", companyId: ctx.input.fixtures.company.id, personal: { definitionId: String(state.definitionId), userId: String(state.currentPersonId), - viaMySecrets: !!question || !!confirmation || !!state.personalMenuNavigation, + viaMySecrets: !!question || !!confirmation, }, baseURL: initial.origin, setupURL: url.href,