From 18d416349427385b1356ebc3d6396f2da1fb6856 Mon Sep 17 00:00:00 2001 From: "Harold Kim (Git Expert)" Date: Thu, 9 Jul 2026 04:46:50 +0000 Subject: [PATCH] fix(codex-local): address Greptile review comments - Widen warning message to cover both configured API key and host auth shadowing scenarios ("configured or host credentials take precedence") - Re-export auth-precedence symbols from server index.ts so downstream imports from @paperclipai/adapter-codex-local/server resolve correctly - Update constant stability test to match updated warning text Co-Authored-By: Paperclip --- .../codex-local/src/server/auth-precedence.test.ts | 2 +- .../adapters/codex-local/src/server/auth-precedence.ts | 2 +- packages/adapters/codex-local/src/server/index.ts | 9 +++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/adapters/codex-local/src/server/auth-precedence.test.ts b/packages/adapters/codex-local/src/server/auth-precedence.test.ts index 375068ced74..17b0c31ba79 100644 --- a/packages/adapters/codex-local/src/server/auth-precedence.test.ts +++ b/packages/adapters/codex-local/src/server/auth-precedence.test.ts @@ -100,7 +100,7 @@ describe("resolveCodexAuthPrecedence", () => { describe("constants", () => { it("warning message is stable and human-readable", () => { expect(CODEX_SANDBOX_AUTH_PRECEDENCE_WARNING).toBe( - "snapshot login present but host credentials take precedence", + "snapshot login present but configured or host credentials take precedence", ); }); diff --git a/packages/adapters/codex-local/src/server/auth-precedence.ts b/packages/adapters/codex-local/src/server/auth-precedence.ts index 0baaf443906..75558b88a8a 100644 --- a/packages/adapters/codex-local/src/server/auth-precedence.ts +++ b/packages/adapters/codex-local/src/server/auth-precedence.ts @@ -1,5 +1,5 @@ export const CODEX_SANDBOX_AUTH_PRECEDENCE_WARNING = - "snapshot login present but host credentials take precedence"; + "snapshot login present but configured or host credentials take precedence"; export const CODEX_SANDBOX_AUTH_PRECEDENCE_WARNING_LOG_LINE = `[paperclip] Warning: ${CODEX_SANDBOX_AUTH_PRECEDENCE_WARNING}.\n`; export const CODEX_SANDBOX_AUTH_EXISTS_COMMAND = diff --git a/packages/adapters/codex-local/src/server/index.ts b/packages/adapters/codex-local/src/server/index.ts index e5b4e725475..da71b1c7769 100644 --- a/packages/adapters/codex-local/src/server/index.ts +++ b/packages/adapters/codex-local/src/server/index.ts @@ -1,4 +1,13 @@ export { execute, ensureCodexSkillsInjected } from "./execute.js"; +export { + resolveCodexAuthPrecedence, + CODEX_SANDBOX_AUTH_PRECEDENCE_WARNING, + CODEX_SANDBOX_AUTH_PRECEDENCE_WARNING_LOG_LINE, + CODEX_SANDBOX_AUTH_EXISTS_COMMAND, + type CodexAuthPrecedenceInput, + type CodexAuthPrecedenceResolution, + type CodexAuthPrecedenceWinner, +} from "./auth-precedence.js"; export { reconcileManagedCodexHome, isManagedCodexHomePath,