Make project workspace changes tab load stale diff plugin

This commit is contained in:
Dotta committed 2026-05-15 12:54:28 -05:00
1 parent bf7460227d
commit 0bb4c712ad
3 files changed
+48 -23

No files matched your search

+16 -13
View File
@@ -55,20 +55,23 @@ vi.mock("@/plugins/slots", () => ({
},
usePluginSlots: (filters: unknown) => {
mockUsePluginSlots(filters);
const entityType = (filters as { entityType?: string }).entityType;
return {
slots: [
{
id: "workspace-changes-tab",
type: "detailTab",
displayName: "Changes",
exportName: "WorkspaceChangesTab",
entityTypes: ["project_workspace"],
pluginId: "plugin-1",
pluginKey: "paperclip.workspace-diff",
pluginDisplayName: "Workspace Diff",
pluginVersion: "0.1.0",
},
],
slots: entityType === "execution_workspace"
? [
{
id: "workspace-changes-tab",
type: "detailTab",
displayName: "Changes",
exportName: "WorkspaceChangesTab",
entityTypes: ["execution_workspace"],
pluginId: "plugin-1",
pluginKey: "paperclip.workspace-diff",
pluginDisplayName: "Workspace Diff",
pluginVersion: "0.1.0",
},
]
: [],
isLoading: false,
errorMessage: null,
};
+26 -4
View File
@@ -278,6 +278,16 @@ export function ProjectWorkspaceDetail() {
companyId: project?.companyId ?? null,
enabled: Boolean(project?.companyId),
});
const {
slots: legacyWorkspacePluginDetailSlots,
isLoading: legacyWorkspacePluginDetailSlotsLoading,
errorMessage: legacyWorkspacePluginDetailSlotsError,
} = usePluginSlots({
slotTypes: ["detailTab"],
entityType: "execution_workspace",
companyId: project?.companyId ?? null,
enabled: Boolean(project?.companyId),
});
const pluginTabItems = useMemo(
() => pluginDetailSlots.map((slot) => ({
value: `plugin:${slot.pluginKey}:${slot.id}`,
@@ -286,7 +296,19 @@ export function ProjectWorkspaceDetail() {
})),
[pluginDetailSlots],
);
const changesPluginTab = pluginTabItems.find((item) => item.value === WORKSPACE_CHANGES_PLUGIN_TAB) ?? null;
const legacyWorkspacePluginTabItems = useMemo(
() => legacyWorkspacePluginDetailSlots.map((slot) => ({
value: `plugin:${slot.pluginKey}:${slot.id}`,
label: slot.displayName,
slot,
})),
[legacyWorkspacePluginDetailSlots],
);
const changesPluginTab = pluginTabItems.find((item) => item.value === WORKSPACE_CHANGES_PLUGIN_TAB)
?? legacyWorkspacePluginTabItems.find((item) => item.value === WORKSPACE_CHANGES_PLUGIN_TAB)
?? null;
const changesPluginTabLoading = pluginDetailSlotsLoading || legacyWorkspacePluginDetailSlotsLoading;
const changesPluginTabError = pluginDetailSlotsError ?? legacyWorkspacePluginDetailSlotsError;
useEffect(() => {
if (!project?.companyId || project.companyId === selectedCompanyId) return;
@@ -726,9 +748,9 @@ export function ProjectWorkspaceDetail() {
/>
) : (
<div className="rounded-lg border border-dashed border-border bg-background px-4 py-8 text-sm text-muted-foreground">
{pluginDetailSlotsError
? `Workspace changes failed to load: ${pluginDetailSlotsError}`
: pluginDetailSlotsLoading
{changesPluginTabError
? `Workspace changes failed to load: ${changesPluginTabError}`
: changesPluginTabLoading
? "Loading workspace changes..."
: "Workspace changes are not available."}
</div>