diff --git a/tests/runner-e2e/chat-catalog-domains/external-company-secret.test.ts b/tests/runner-e2e/chat-catalog-domains/external-company-secret.test.ts index 4bf5b080d35..aa250f42822 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-company-secret.test.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-company-secret.test.ts @@ -11,7 +11,9 @@ import type { ChatCatalogContext } from "../chat-catalog-contract.js"; import { companySecretApprovalCandidate,companySecretApprovalProof,companyOperatorBindingRequested,companySecretQuestionHandoff,companySecretExternalCases,deploymentSecretGuidance,companySecretControllerBaseline,companySecretControllersUnchanged,companySecretFollowup } from "./external-company-secret.js"; const controller={id:"controller",companyId:"company",scope:"company",ownerUserId:null,userSecretDefinitionId:null,key:"openrouter_api_key",name:"Runner E2E controller",provider:"local_encrypted",status:"active",managedMode:"paperclip_managed",latestVersion:1}; const controllerRefs={OPENROUTER_API_KEY:{type:"secret_ref",secretId:"controller",version:"latest"}} as const; -function valid(){return {scenarioId:"secrets.configure-company-secret",companyId:"company",leadId:"ceo",reply:"The deployment key reference is now bound for Morgan. This confirms configuration, not a runtime delivery test.",phaseReplies:[{runId:"first",commentId:"first-reply",body:"Use secure secret settings for the deployment key, then bind its reference in Morgan's environment variables. Do not paste the key here."},{runId:"second",body:"The deployment key reference is now bound for Morgan. This confirms configuration, not a runtime delivery test."}],runs:[{id:"first",status:"succeeded"},{id:"second",status:"succeeded"}],connections:[],profiles:[],secrets:[{id:"secret",name:"Deployment API key",status:"active"}],endpoints:[],interactions:[],activity:[{entityId:"secret",action:"secret.created",actorType:"user",actorId:"person"}],links:[],humanQueries:[],state:{replyLinkProof:{commentId:"first-reply",route:"http://paperclip.test/COM/company/settings/secrets",linkText:"Secrets",reachedSecretEntry:true} as Record|undefined,morganConfigBefore:{env:{}},morganConfigAfter:{env:{DEPLOYMENT_API_KEY:{type:"secret_ref",secretId:"secret",version:"latest"}}},morganOtherConfigBefore:{adapterType:"paperclip_runner"},morganOtherConfigAfter:{adapterType:"paperclip_runner"},bindingEnvironmentName:"DEPLOYMENT_API_KEY",currentPersonId:"person",initialRunId:"first",agentCreateStatus:403,secretCountBeforeHuman:1,controllerSecretBaseline:[controller],controllerSecretsPreserved:true,operatorChannel:"private-browser-company-secret-and-public-browser-binding",secretUiVisible:true,humanSubmittedSecurely:true,storageClean:true,secureBrowserUntraced:true,secretId:"secret",morganId:"morgan",bindings:[{targetType:"agent",targetId:"morgan",configPath:"env.DEPLOYMENT_API_KEY",versionSelector:"latest"}],savedReferenceMatches:true,morganBindingVisible:true,bindingHumanAttributed:true,secretScanComplete:true,secretLeaked:false}};} +// The confirming reply as saved: posted by the bound continuation run after the Morgan binding existed. +const confirmingReply={id:"second-reply",companyId:"company",issueId:"source",authorAgentId:"ceo",createdByRunId:"second",createdAt:"2026-11-04T13:42:00Z",body:"The deployment key reference is now bound for Morgan. This confirms configuration, not a runtime delivery test."}; +function valid(){return {scenarioId:"secrets.configure-company-secret",companyId:"company",leadId:"ceo",reply:"The deployment key reference is now bound for Morgan. This confirms configuration, not a runtime delivery test.",phaseReplies:[{runId:"first",commentId:"first-reply",body:"Use secure secret settings for the deployment key, then bind its reference in Morgan's environment variables. Do not paste the key here."},{runId:"second",commentId:"second-reply",body:"The deployment key reference is now bound for Morgan. This confirms configuration, not a runtime delivery test."}],runs:[{id:"first",status:"succeeded"},{id:"second",status:"succeeded"}],connections:[],profiles:[],secrets:[{id:"secret",name:"Deployment API key",status:"active"}],endpoints:[],interactions:[],activity:[{entityId:"secret",action:"secret.created",actorType:"user",actorId:"person"}],links:[],humanQueries:[],state:{replyLinkProof:{commentId:"first-reply",route:"http://paperclip.test/COM/company/settings/secrets",linkText:"Secrets",reachedSecretEntry:true} as Record|undefined,morganConfigBefore:{env:{}},morganConfigAfter:{env:{DEPLOYMENT_API_KEY:{type:"secret_ref",secretId:"secret",version:"latest"}}},morganOtherConfigBefore:{adapterType:"paperclip_runner"},morganOtherConfigAfter:{adapterType:"paperclip_runner"},bindingEnvironmentName:"DEPLOYMENT_API_KEY",currentPersonId:"person",initialRunId:"first",agentCreateStatus:403,secretCountBeforeHuman:1,controllerSecretBaseline:[controller],controllerSecretsPreserved:true,operatorChannel:"private-browser-company-secret-and-public-browser-binding",secretUiVisible:true,humanSubmittedSecurely:true,storageClean:true,secureBrowserUntraced:true,secretId:"secret",morganId:"morgan",bindings:[{secretId:"secret",targetType:"agent",targetId:"morgan",configPath:"env.DEPLOYMENT_API_KEY",versionSelector:"latest",createdAt:"2026-11-04T13:41:00Z"}],sourceIssueId:"source",companySourceComments:[{...confirmingReply}] as Array&{id:string;createdAt:string}>,savedReferenceMatches:true,morganBindingVisible:true,bindingHumanAttributed:true,secretScanComplete:true,secretLeaked:false}};} describe("secure company credential and Morgan-only binding",()=>{ const definition=companySecretExternalCases[0]!; it("accepts actual human UI entry/reference binding and a separate metadata confirmation",()=>expect(definition.grade(valid()).passed).toBe(true)); @@ -31,7 +33,14 @@ describe("secure company credential and Morgan-only binding",()=>{ (o:ReturnType)=>{o.state.secretScanComplete=false;}, (o:ReturnType)=>{o.state.secretLeaked=true;}, (o:ReturnType)=>{o.phaseReplies[1]!.runId="first";}, - (o:ReturnType)=>{o.phaseReplies[1]!.body="Morgan's deployment key is not yet bound or available.";}, + // The confirming reply is graded from saved state, not wording. + (o:ReturnType)=>{o.state.companySourceComments=[];}, + (o:ReturnType)=>{o.state.companySourceComments[0]!.createdAt="2026-11-04T13:40:00Z";}, + (o:ReturnType)=>{o.state.companySourceComments[0]!.createdByRunId="first";}, + (o:ReturnType)=>{o.state.companySourceComments[0]!.authorAgentId="morgan";}, + (o:ReturnType)=>{o.state.companySourceComments[0]!.issueId="other";}, + (o:ReturnType)=>{o.state.bindings[0]!.configPath="env.OTHER_API_KEY";}, + (o:ReturnType)=>{delete (o.state.bindings[0] as Record).createdAt;}, // The setup reply is graded by its followed link, not its wording. (o:ReturnType)=>{o.state.replyLinkProof=undefined;}, (o:ReturnType)=>{o.state.replyLinkProof={...o.state.replyLinkProof,commentId:"unrelated-reply"};}, @@ -240,7 +249,7 @@ it("requires native saved-name binding and exact metadata-only question accounti function commentNativeOutcome(){ const o=valid(),body="Use secure Settings Secrets for the deployment key. Once saved I'll add its secret reference to Morgan's environment. Tell me the name/key you used (not the value)."; const followup="Saved as deployment_api_key. Please finish the requested Morgan setup."; - return {...o,phaseReplies:[{runId:"first",commentId:"first-reply",body},{runId:"second",body:o.phaseReplies[1]!.body}],runs:[{id:"first",companyId:"company",agentId:"ceo",runtimeMode:"native",status:"succeeded",startedAt:"2026-11-04T13:00:00Z",finishedAt:"2026-11-04T13:30:00Z",contextSnapshot:{issueId:"source",commentId:"initial-human"}},{id:"second",companyId:"company",agentId:"ceo",runtimeMode:"native",status:"succeeded",startedAt:"2026-11-04T13:40:01Z",contextSnapshot:{issueId:"source",commentId:"followup-human"}}],secrets:[{...o.secrets[0],companyId:"company",scope:"company",key:"deployment_api_key",createdAt:"2026-11-04T13:35:00Z",createdByUserId:"person"}],activity:[...o.activity,{companyId:"company",entityId:"morgan",action:"agent.updated",actorType:"agent",actorId:"ceo",runId:"second",createdAt:"2026-11-04T13:41:00Z"}],state:{...o.state,sourceIssueId:"source",operatorChannel:"private-browser-company-secret-and-native-binding",morganConfigBefore:{env:{}},morganConfigAfter:{env:{DEPLOYMENT_API_KEY:{type:"secret_ref",secretId:"secret",version:"latest"}}},morganOtherConfigBefore:{adapterType:"paperclip_runner"},morganOtherConfigAfter:{adapterType:"paperclip_runner"},followupCommentId:"followup-human",followupCreatedAt:"2026-11-04T13:40:00Z",followupBody:followup,companySourceComments:[{id:"followup-human",companyId:"company",issueId:"source",authorUserId:"person",createdAt:"2026-11-04T13:40:00Z",body:followup}]}}; + return {...o,phaseReplies:[{runId:"first",commentId:"first-reply",body},{runId:"second",commentId:"second-reply",body:o.phaseReplies[1]!.body}],runs:[{id:"first",companyId:"company",agentId:"ceo",runtimeMode:"native",status:"succeeded",startedAt:"2026-11-04T13:00:00Z",finishedAt:"2026-11-04T13:30:00Z",contextSnapshot:{issueId:"source",commentId:"initial-human"}},{id:"second",companyId:"company",agentId:"ceo",runtimeMode:"native",status:"succeeded",startedAt:"2026-11-04T13:40:01Z",contextSnapshot:{issueId:"source",commentId:"followup-human"}}],secrets:[{...o.secrets[0],companyId:"company",scope:"company",key:"deployment_api_key",createdAt:"2026-11-04T13:35:00Z",createdByUserId:"person"}],activity:[...o.activity,{companyId:"company",entityId:"morgan",action:"agent.updated",actorType:"agent",actorId:"ceo",runId:"second",createdAt:"2026-11-04T13:41:00Z"}],state:{...o.state,sourceIssueId:"source",operatorChannel:"private-browser-company-secret-and-native-binding",morganConfigBefore:{env:{}},morganConfigAfter:{env:{DEPLOYMENT_API_KEY:{type:"secret_ref",secretId:"secret",version:"latest"}}},morganOtherConfigBefore:{adapterType:"paperclip_runner"},morganOtherConfigAfter:{adapterType:"paperclip_runner"},followupCommentId:"followup-human",followupCreatedAt:"2026-11-04T13:40:00Z",followupBody:followup,companySourceComments:[{id:"followup-human",companyId:"company",issueId:"source",authorUserId:"person",createdAt:"2026-11-04T13:40:00Z",body:followup},{...confirmingReply}]}}; } it("binds native comment continuation to the actual metadata-only human followup and permits idempotent binding retries",()=>{ const o=commentNativeOutcome();expect(o.state.followupBody).toBe("Saved as deployment_api_key. Please finish the requested Morgan setup."); @@ -292,6 +301,16 @@ it("keeps completed operator questions bound across whitespace without borrowing expect(companyOperatorBindingRequested("Have you configured the secret in Settings Secrets\nI will bind the reference for Morgan.","Have you configured the secret in Settings Secrets")).toBe(false); }); +// Saved state the confirmation grade reads: each later reply's comment, posted by its run after the binding existed. +function withSavedConfirmation;state:Record}>(o:T,bindingAt="2026-11-04T13:41:30Z",replyAt="2026-11-04T13:45:00Z"):T{ + for(const binding of o.state.bindings??[])binding.createdAt??=bindingAt; + const rows=[...(o.state.companySourceComments??[])]; + for(const reply of o.phaseReplies.filter(row=>row.runId!==o.state.initialRunId)){ + reply.commentId??=`${reply.runId}-reply`; + if(!rows.some(row=>row.id===reply.commentId))rows.push({id:reply.commentId,companyId:"company",issueId:"source",authorAgentId:"ceo",createdByRunId:reply.runId,createdAt:replyAt,body:reply.body}); + } + o.state.companySourceComments=rows;o.state.sourceIssueId??="source";return o; +} function governedCompanyOutcome(){ const base=commentNativeOutcome();base.state.morganId="44444444-4444-4444-8444-444444444444"; const proposal={id:"33333333-3333-4333-8333-333333333333",companyId:"company",kind:"binding",status:"pending",secretId:"secret",secretName:"Deployment API key",secretProposalId:null,targetType:"agent",target:{id:"44444444-4444-4444-8444-444444444444",name:"Morgan"},configPath:"env.DEPLOYMENT_API_KEY",originRunId:"second",originIssue:{id:"source"},proposedBy:{id:"ceo"},viewerCanApprove:true,appliedBindingConfigPath:null,resolvedByUserId:null,createdAt:"2026-11-04T13:41:00Z",expiresAt:"2026-11-18T13:41:00Z"} as SecretProposalView; @@ -306,6 +325,7 @@ function governedCompanyOutcome(){ o.runs.push({id:"third",companyId:"company",agentId:"ceo",status:"succeeded",runtimeMode:"native",startedAt:"2026-11-04T13:42:01Z",contextSnapshot:{issueId:"source",interactionId:"approval"}}); o.phaseReplies=[o.phaseReplies[0]!,{runId:"third",body:"The deployment key reference is bound and available to Morgan. Configuration is verified; runtime delivery was not tested."}]; o.activity.push({id:"accepted-audit",companyId:"company",entityId:"source",action:"issue.thread_interaction_accepted",actorType:"user",actorId:"person",createdAt:"2026-11-04T13:42:00Z",details:{interactionId:"approval"}},{id:"proposal-audit",companyId:"company",entityId:"33333333-3333-4333-8333-333333333333",action:"secret.proposal.approved",actorType:"user",actorId:"person",createdAt:"2026-11-04T13:42:00Z",details:{appliedBindingConfigPath:"env.DEPLOYMENT_API_KEY"}},{id:"binding-audit",companyId:"company",entityId:"44444444-4444-4444-8444-444444444444",action:"agent.updated",actorType:"user",actorId:"person",createdAt:"2026-11-04T13:42:00Z",details:{proposalId:"33333333-3333-4333-8333-333333333333",configPath:"env.DEPLOYMENT_API_KEY"}}); + withSavedConfirmation(o); return {o,card,proposal,marker}; } it("keeps a real pending governed binding partial until human execution and bound native confirmation",()=>{ @@ -373,7 +393,7 @@ function confirmationOutcome(){ o.activity[0]={id:"save",companyId:"company",entityId:"secret",action:"secret.created",actorType:"user",actorId:"person",createdAt:"2026-11-04T13:35:00Z"}; o.activity.push({id:"accepted",companyId:"company",entityId:"source",action:"issue.thread_interaction_accepted",actorType:"user",actorId:"person",createdAt:"2026-11-04T13:40:00Z",details:{interactionId:"ack",interactionKind:"request_confirmation",interactionStatus:"accepted"}}); Object.assign(o.state,{initialConfirmationId:"ack",initialConfirmationContinuationPolicy:"wake_assignee",initialConfirmationPayloadHash:createHash("sha256").update(JSON.stringify(payload)).digest("hex"),canonicalHumanCommentId:"initial-human",confirmationVisibleBeforeEntry:true,confirmationAnsweredThroughUi:true,confirmationResponseVerified:true,requestedCompanyName:"Deployment API Key",requestedCompanyKey:"DEPLOYMENT_API_KEY",savedCompanyName:"Deployment API Key",savedCompanyKey:"deployment_api_key",companySourceComments:[{id:"initial-human",companyId:"company",issueId:"source",authorUserId:"person",createdAt:"2026-11-04T12:59:00Z",body:"Add our deployment API key so Morgan can use it."}]}); - return o; + return withSavedConfirmation(o); } it("counts only a saved current-human confirmation and proves its actual bound native binding",()=>{ const o=confirmationOutcome(),definition=companySecretExternalCases[0]!,grade=definition.grade(o); @@ -392,6 +412,7 @@ it("keeps secure-save ACK and the later executed binding approval as distinct re const {o,card,marker}=governedCompanyOutcome(),direct=confirmationOutcome(),ack=direct.interactions[0]!; o.interactions.push(ack);o.phaseReplies=o.phaseReplies.filter(reply=>reply.runId!=="first"); for(const key of ["initialConfirmationId","initialConfirmationPayloadHash","initialConfirmationContinuationPolicy","canonicalHumanCommentId","confirmationVisibleBeforeEntry","confirmationAnsweredThroughUi","confirmationResponseVerified","requestedCompanyName","requestedCompanyKey","savedCompanyName","savedCompanyKey","companySourceComments"])o.state[key]=direct.state[key]; + withSavedConfirmation(o); Object.assign(o.secrets[0]!,{name:"Deployment API Key"});Object.assign(o.runs[0]!,{exitCode:0});Object.assign(o.runs[1]!,{exitCode:0,contextSnapshot:{issueId:"source",interactionId:"ack"}}); o.activity[0]=direct.activity[0]!;o.activity.push(direct.activity.at(-1)!); card.payload.secretProposal!.sourceSecretLabel="Deployment API Key"; @@ -428,3 +449,15 @@ it("accepts the cohort 5 secure Secrets-page guidance and rejects the same guida expect(deploymentSecretGuidance(reply)).toBe(true); expect(deploymentSecretGuidance(reply.replace("paste the value.", "and paste the value here so I can save it."))).toBe(false); }); + +// Paid run 43409187232: the bound continuation confirmed the applied binding in words the old wording +// patterns did not list ("applied", "exposes"), so a correct outcome failed. The grade now reads saved state. +it("accepts the retained post-authorization confirmation from saved state and rejects it when posted before the binding", () => { + const retained = "Morgan's setup is finished. The saved \"Deployment API key\" is active, and the binding you approved is applied: Morgan's configuration now exposes it as the environment variable `DEPLOYMENT_API_KEY`, referencing the company secret (configuration updated 11:02 UTC). Morgan is idle now, so the key will be delivered into its environment when it next runs. You can see the binding on [Morgan's secrets page](/COM/agents/morgan/secrets)."; + const o = valid(); + o.phaseReplies[1]!.body = retained; o.reply = retained; o.state.companySourceComments[0]!.body = retained; + const grade = companySecretExternalCases[0]!.grade(o); + expect(grade.passed, JSON.stringify(grade.checks.filter(check => !check.passed))).toBe(true); + o.state.companySourceComments[0]!.createdAt = "2026-11-04T13:40:59Z"; + expect(companySecretExternalCases[0]!.grade(o).checks.find(check => check.id === "human-attributed-and-confirmed-after-authorization")?.passed).toBe(false); +}); diff --git a/tests/runner-e2e/chat-catalog-domains/external-company-secret.ts b/tests/runner-e2e/chat-catalog-domains/external-company-secret.ts index a57ad9d817f..2379f050bda 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-company-secret.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-company-secret.ts @@ -1,5 +1,5 @@ import {canonicalCompanySecretKey,companySecretConfirmationHandoff,visibleCompanySecretConfirmationURL,acceptCompanySecretConfirmation} from "./external-company-secret-confirmation.js"; -import { truthfulPendingProposal,truthfulProposalPhase } from "./external-secret-proposal.js"; +import { truthfulPendingProposal } from "./external-secret-proposal.js"; import { pollUntil } from "../api.js"; import {isDeepStrictEqual} from "node:util"; import {visibleSecretSettingsURL} from "./external-secret-route.js"; @@ -192,7 +192,20 @@ export function gradeCompanySecret(value:unknown){ const nativeBindingAuthorized=continuationValid&&mutations.length>=1&&mutations.every(row=>row.companyId===o.companyId&&row.entityId===o.state.morganId&&row.actorType==="agent"&&row.actorId===o.leadId&&(row as typeof row&{runId?:string}).runId===continuation!.id&&/agent\.(?:updated|config_updated)/.test(row.action??"")&&Date.parse(String(row.createdAt))>=inputAt); c.add("bounded-governed-company-path",o.runs.length===(approval?3:2)&&(!o.state.companySecretApproval||!!approval),"Direct paths use exactly two native runs; a third requires actual current-human executed proposal approval and its bound continuation."); c.add("one-intended-reference-and-consumer",o.secrets.filter(row=>row.id===o.state.secretId&&row.name===(confirmation?o.state.savedCompanyName:"Deployment API key")&&row.status==="active").length===1&&Array.isArray(bindings)&&bindings.length===1&&bindings[0]?.targetType==="agent"&&bindings[0]?.targetId===o.state.morganId&&bindings[0]?.configPath===`env.${chosenEnvironment}`&&bindings[0]?.versionSelector==="latest"&&o.state.savedReferenceMatches===true&&!!chosenEnvironment&&o.state.morganBindingVisible===true,"The saved secret has exactly Morgan's intended latest-version environment reference; neither plaintext nor a company-wide grant is substituted."); - c.add("human-attributed-and-confirmed-after-authorization",o.activity.some(row=>row.entityId===o.state.secretId&&row.action==="secret.created"&&row.actorType==="user"&&row.actorId===o.state.currentPersonId)&&(savedNameBinding?!!approval||nativeBindingAuthorized:o.state.bindingHumanAttributed===true)&&later.some(reply=>o.runs.some(run=>run.id===reply.runId&&run.status==="succeeded"&&(!nativeBindingRequired||(approval?run.id===approval.continuationRunId:continuationValid&&run.id===continuation!.id)))&&(!(o.state.initialQuestionId||o.state.initialConfirmationId)||((questionAnswered||!!confirmation)&&o.runs.find(run=>run.id===reply.runId)?.contextSnapshot?.interactionId===(approval?.interactionId??question?.interactionId??confirmation?.interactionId)))&&(!approval||truthfulProposalPhase(reply.body,true))&&/Morgan/i.test(reply.body)&&/deploy/i.test(reply.body)&&/bound|available|configured|ready|added/i.test(reply.body)&&!/\bnot(?: yet)?\s+(?:bound|available|configured|ready|added)\b|\b(?:will|would)\s+be\s+(?:bound|available|configured|ready|added)\b/i.test(reply.body)&&!solicitsChatCredential(reply.body)),"A separate successful post-authorization model run confirms the intended binding metadata, without claiming a runtime delivery test occurred."); +// The confirming reply is graded from saved state, not wording: the bound post-authorization run posted it, + // after the intended Morgan binding existed. Its wording is left to human review. + const intendedBinding=Array.isArray(bindings)&&bindings.length===1&&bindings[0]?.targetType==="agent"&&bindings[0].targetId===o.state.morganId + &&bindings[0].secretId===o.state.secretId&&!!chosenEnvironment&&bindings[0].configPath===`env.${chosenEnvironment}`?bindings[0]:undefined; + const bindingAt=Date.parse(String((intendedBinding as {createdAt?:unknown}|undefined)?.createdAt)); + const confirmingRunId=nativeBindingRequired?(approval?approval.continuationRunId:continuationValid?continuation!.id:undefined):undefined; + const confirmedAfterBinding=later.some(reply=>{ + const comment=followupRows.find(row=>row.id===reply.commentId),run=o.runs.find(row=>row.id===reply.runId); + return !!comment&&!!run&&run.status==="succeeded"&&comment.companyId===o.companyId&&comment.issueId===o.state.sourceIssueId + &&comment.authorAgentId===o.leadId&&!comment.authorUserId&&comment.createdByRunId===run.id&&(!nativeBindingRequired||run.id===confirmingRunId) + &&(!(o.state.initialQuestionId||o.state.initialConfirmationId)||((questionAnswered||!!confirmation)&&run.contextSnapshot?.interactionId===(approval?.interactionId??question?.interactionId??confirmation?.interactionId))) + &&Number.isFinite(bindingAt)&&Date.parse(comment.createdAt)>=bindingAt; + }); + c.add("human-attributed-and-confirmed-after-authorization",o.activity.some(row=>row.entityId===o.state.secretId&&row.action==="secret.created"&&row.actorType==="user"&&row.actorId===o.state.currentPersonId)&&(savedNameBinding?!!approval||nativeBindingAuthorized:o.state.bindingHumanAttributed===true)&&confirmedAfterBinding,"A separate successful post-authorization model run posted its reply after the intended Morgan binding existed; the reply's wording is left to human review."); c.add("no-credential-in-public-outputs",o.state.secretScanComplete===true&&o.state.secretLeaked===false,"Private byte scans cover source/descendant documents, historical revisions, attachments, artifacts and actual run events before redaction.");return c.result(); } export const companySecretExternalCases=[definition("secrets.configure-company-secret",async ctx=>{ @@ -322,7 +335,8 @@ export const companySecretExternalCases=[definition("secrets.configure-company-s async observe(ctx,state){ const o=await observeExternal(ctx,state),value=values.get(ctx); if(state.companySecretApproval)state.companyBindingProposals=await ctx.input.api.get(`${root(ctx)}/secret-proposals`); - if(state.followupCommentId||state.initialConfirmationId||state.companySecretApproval)state.companySourceComments=await ctx.input.api.get(`/api/issues/${state.sourceIssueId}/comments?order=asc`); + // Saved source comments bind the final reply to its run and time; every path needs them. + state.companySourceComments=await ctx.input.api.get(`/api/issues/${state.sourceIssueId}/comments?order=asc`); state.controllerSecretsPreserved=Array.isArray(state.controllerSecretBaseline)&&o.secrets.length===state.controllerSecretBaseline.length+1&&o.secrets.filter(row=>row.id===state.secretId).length===1&&companySecretControllersUnchanged(o.secrets as unknown as CompanySecret[],state.controllerSecretBaseline); if(!value||!ctx.issue())throw new Error("Private secret output scan fixture missing"); state.bindings=(await ctx.input.api.get<{bindings:CompanySecretUsageBinding[]}>(`/api/secrets/${state.secretId}/usage`)).bindings;