fix: address accounting recovery and budget review findings

Co-Authored-By: Paperclip <noreply@paperclip.ing>

scripts/test-accounting-mutations.mjs

@@ -1,34 +1,47 @@
 import { spawn } from "node:child_process";
-import { mkdtemp, readFile, rm, writeFile, mkdir } from "node:fs/promises";
+import { mkdtemp, readFile, rm, writeFile, mkdir, copyFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 const root = fileURLToPath(new URL("..", import.meta.url));
 const directory = await mkdtemp(path.join(tmpdir(), "accounting-mutations-"));
+const artifactDirectory = path.join(root, "coverage/accounting/mutations");
 const targets = { deduplication: "deduplicates a retried receipt", company: "isolates company reporting", projection: "conserves agent projections", threshold: "stops at the exact budget boundary" };
 const evidence = [];
+const persist = () => writeFile(path.join(root, "coverage/accounting/mutations.json"), JSON.stringify({ generatedAt: new Date().toISOString(), evidence }, null, 2));
+await mkdir(artifactDirectory, { recursive: true });
 try {
   for (const name of ["baseline", ...Object.keys(targets)]) {
     const report = path.join(directory, `${name}.json`);
-    const result = await new Promise((resolve, reject) => {
+    const entry = { mutation: name, result: "error", assertions: [] };
+    evidence.push(entry);
+    await persist();
+    const result = await new Promise((resolve) => {
       const child = spawn(process.execPath, ["node_modules/vitest/vitest.mjs", "run", "--config", "server/vitest.accounting-mutations.config.ts", "--reporter=json", `--outputFile=${report}`], {
         cwd: root, env: { ...process.env, PAPERCLIP_ACCOUNTING_MUTATION: name === "baseline" ? "" : name }, stdio: ["ignore", "pipe", "pipe"],
       });
       let log = ""; const capture = data => { log += data; };
       child.stdout.on("data", capture); child.stderr.on("data", capture);
-      child.once("error", reject); child.once("exit", code => resolve({ code, log }));
+      child.once("error", error => resolve({ code: null, log: `${log}\n${error.message}` }));
+      child.once("close", code => resolve({ code, log }));
     });
+    await writeFile(path.join(artifactDirectory, `${name}.log`), result.log);
+    await copyFile(report, path.join(artifactDirectory, `${name}.json`)).catch(() => {});
     const json = JSON.parse(await readFile(report, "utf8").catch(() => { throw new Error(`${name} produced no test evidence: ${result.log}`); }));
     const assertions = json.testResults.flatMap(file => file.assertionResults);
+    entry.assertions = assertions.map(({ title, status }) => ({ title, status }));
     if (name === "baseline") {
-      if (result.code !== 0 || assertions.length !== 4 || assertions.some(test => test.status !== "passed")) throw new Error(`Mutation baseline failed or skipped: ${result.log}`);
+      entry.result = result.code === 0 && assertions.length === 4 && assertions.every(test => test.status === "passed") ? "passed" : "baseline_failed";
+      if (entry.result !== "passed") throw new Error(`Mutation baseline failed or skipped: ${result.log}`);
     } else {
       const sentinel = assertions.find(test => test.title === targets[name]);
-      if (result.code === 0 || !result.log.includes(`ACCOUNTING_MUTATION_APPLIED ${name}`) || sentinel?.status !== "failed") throw new Error(`Mutation ${name} survived or failed without its sentinel: ${result.log}`);
+      entry.result = result.code !== 0 && result.log.includes(`ACCOUNTING_MUTATION_APPLIED ${name}`) && sentinel?.status === "failed" ? "killed" : "survived_or_invalid";
+      if (entry.result !== "killed") throw new Error(`Mutation ${name} survived or failed without its sentinel: ${result.log}`);
     }
-    evidence.push({ mutation: name, result: name === "baseline" ? "passed" : "killed", assertions: assertions.map(({ title, status }) => ({ title, status })) });
-    process.stdout.write(`${name}: ${name === "baseline" ? "passed" : "killed by expected assertion"}\n`);
+    await persist();
+    process.stdout.write(`${name}: ${entry.result}\n`);
   }
-  await mkdir(path.join(root, "coverage/accounting"), { recursive: true });
-  await writeFile(path.join(root, "coverage/accounting/mutations.json"), JSON.stringify({ generatedAt: new Date().toISOString(), evidence }, null, 2));
-} finally { await rm(directory, { recursive: true, force: true }); }
+} finally {
+  // Failed baselines, surviving mutants, and missing reports are evidence too.
+  try { await persist(); } finally { await rm(directory, { recursive: true, force: true }); }
+}